Zoltan Ivanfi has posted comments on this change. ( http://gerrit.cloudera.org:8080/8190 )
Change subject: IMPALA-3504: [DOCS] Document utc_timestamp() ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8190/2/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/8190/2/docs/topics/impala_datetime_functions.xml@2543 PS2, Line 2543: For working with date/time values represented as integer values, you can convert The most typical integer timestamp representation is the number of seconds (not microsecs) elapsed since the Unix epoch. It may be worth including specific instructions for dealing with these. If there are no conversion functions for these, then I suggest providing examples incorporating multiplication and division. http://gerrit.cloudera.org:8080/#/c/8190/2/docs/topics/impala_datetime_functions.xml@2545 PS2, Line 2545: with the <codeph>unix_micros_to_utc_timestamp()</codeph> and Shouldn't the unix_micros_to_utc_timestamp and utc_to_unix_micros functions be briefly documented separately as well, just like the from_unixtime and unix_timestamp functions are? At least an indexterm should be added in my opinion. http://gerrit.cloudera.org:8080/#/c/8190/2/docs/topics/impala_datetime_functions.xml@2557 PS2, Line 2557: select now(), utc_timestamp(); (nit, optional) This pairing of functions for the queries seems quite arbitrary to me and makes it hard to compare all three functions. I would suggest examples showing either each function separately (3 queries) or all of them in a single query: select now(), current_timestamp(), utc_timestamp(); -- To view, visit http://gerrit.cloudera.org:8080/8190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2662fc79d588f22a24a5067429a57b3c0d0f0f0 Gerrit-Change-Number: 8190 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-Comment-Date: Mon, 09 Oct 2017 10:22:28 +0000 Gerrit-HasComments: Yes
