Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7805 )
Change subject: IMPALA-5425: Add test for validating input when setting query options ...................................................................... Patch Set 14: Code-Review+1 * The patch covers what I intended. * Still, many existing query options basically don't do error handling. We should fix that, but not in this patch. For example, MAX_ERRORS accepts negative values, or ABORT_ON_ERROR will accept interpret anything that is not "true" or "1" as false, which is not very user friendly. * Too much metaprogramming for my taste, but I won't stand in the way of merging this patch. -- To view, visit http://gerrit.cloudera.org:8080/7805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I510e02bb0776673d8cbfc22b903831882c6908d7 Gerrit-Change-Number: 7805 Gerrit-PatchSet: 14 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 09 Oct 2017 22:50:16 +0000 Gerrit-HasComments: No
