Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8240 )
Change subject: IMPALA-6023: Fix broken breakpad test ...................................................................... IMPALA-6023: Fix broken breakpad test We have a test to make sure that hitting a DCHECK will write a minidump. We used to pass "-beeswax_port=1" to the server to trigger a DCHECK. A while ago, this DCHECK seems to have been removed, but we still called abort() if the ImpalaServer failed to start. This masked the slightly altered behavior and the test still succeeded. However, the fix for IMPALA-4786 changed the behavior to call exit(1) instead of abort() if the ImpalaServer failed to start. To fix the test, we change it to pass an unresolvable hostname to impalad, which will result in a call to abort(). This change also splits the breakpad tests into core and exhaustive sets to make sure that tests which depend on other parts of Impala are included in every core run. Change-Id: Ifb5af3e72963280a6677a99aa6a0e5785443bb0c Reviewed-on: http://gerrit.cloudera.org:8080/8240 Reviewed-by: Michael Brown <[email protected]> Tested-by: Impala Public Jenkins --- M tests/custom_cluster/test_breakpad.py 1 file changed, 33 insertions(+), 23 deletions(-) Approvals: Michael Brown: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifb5af3e72963280a6677a99aa6a0e5785443bb0c Gerrit-Change-Number: 8240 Gerrit-PatchSet: 5 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]>
