Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8051 )
Change subject: IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8051/3/be/src/exprs/decimal-operators-ir.cc File be/src/exprs/decimal-operators-ir.cc: http://gerrit.cloudera.org:8080/#/c/8051/3/be/src/exprs/decimal-operators-ir.cc@613 PS3, Line 613: if (seconds < numeric_limits<int64_t>::min() || : seconds > numeric_limits<int64_t>::max()) { : // TimeStampVal() takes int64_t. : return TimestampVal::null(); > Is this branch now also evaluated for Decimal[4/8]Values? If so, will it ha Good question - my guess is that the compiler is smart enough to eliminate this branch for 4/8. http://gerrit.cloudera.org:8080/#/c/8051/3/be/src/exprs/decimal-operators.h File be/src/exprs/decimal-operators.h: http://gerrit.cloudera.org:8080/#/c/8051/3/be/src/exprs/decimal-operators.h@166 PS3, Line 166: // > nit: Keep comment formatting consistent with the rest of the file. Done http://gerrit.cloudera.org:8080/#/c/8051/3/be/src/exprs/decimal-operators.h@168 PS3, Line 168: TDecimal > Did you follow some other example h No, I just wanted to highlight that this T is a kind of decimal. -- To view, visit http://gerrit.cloudera.org:8080/8051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8216f4c0f100c1bd68891cd6048236bfe4c205f0 Gerrit-Change-Number: 8051 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Wed, 11 Oct 2017 15:44:01 +0000 Gerrit-HasComments: Yes
