Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8255 )
Change subject: IMPALA-5940: Avoid log spew by using Status::Expected() ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8255/1/be/src/rpc/thrift-client.cc File be/src/rpc/thrift-client.cc: http://gerrit.cloudera.org:8080/#/c/8255/1/be/src/rpc/thrift-client.cc@71 PS1, Line 71: } > I think we should make it clear why we use Expected() when we do (since we Done http://gerrit.cloudera.org:8080/#/c/8255/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/8255/1/be/src/service/impala-server.cc@1173 PS1, Line 1173: INTERNAL_ERROR > hmm, if this is expected (as the comment claims), then this shouldn't be an Fixed. Was just preserving the previous logic. -- To view, visit http://gerrit.cloudera.org:8080/8255 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87493394074a7fdb4e912f4ab2436dd7050d45b3 Gerrit-Change-Number: 8255 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Wed, 11 Oct 2017 18:59:26 +0000 Gerrit-HasComments: Yes
