Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8262 )
Change subject: IMPALA-6045: Make build scripts more friendly to Ubuntu 16.04 ...................................................................... Patch Set 3: (2 comments) Sorry to get to this a bit late. I find the distinctions between the (now 3) bootstrap_* scripts to be really hard to grok. Since we're multiplying scripts in this commit, it seems like we should clarify those distinctions. I very much like separating bootstrap_system from bootstrap_development, but I think it doesn't make sense to separate it into two scripts. Rather, I think this would be clearer to use if it looked like: bootstrap_development [install-packages] [checkout-impala] [configure] [build] [loadtestdata] [runtests] (Or something like it; point being to have on entry point with a few variants.) The default actions would be whatever bootstrap_development does today. There's a mild prototype at https://github.com/philz/incubator-impala/commit/e0e7ad3ce07335709987b1b4088ac66ef312e7af if you're interested. This came up for me while trying to time the different parts of the bootstrap script for some Docker work I was doing. In it, I just broke the existing script into ~5 bash functions. http://gerrit.cloudera.org:8080/#/c/8262/3/bin/bootstrap_build.sh File bin/bootstrap_build.sh: http://gerrit.cloudera.org:8080/#/c/8262/3/bin/bootstrap_build.sh@35 PS3, Line 35: python-dev python-setuptools libffi-dev libkrb5-dev Consider just adding openjdk-${JDK_VERSION}-jdk (and friends) here? I don't know that one apt-get command is faster than two, but it's nice to have them all together. http://gerrit.cloudera.org:8080/#/c/8262/3/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/8262/3/bin/bootstrap_system.sh@20 PS3, Line 20: # This script bootstraps a system for Impala development from almost nothing; it is known This is very heavily replicated with bootstrap_development; highlighting the differences may make sense. -- To view, visit http://gerrit.cloudera.org:8080/8262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8196a2a87bce5893a349a1b290c3f3d04fd80317 Gerrit-Change-Number: 8262 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Fri, 13 Oct 2017 16:54:34 +0000 Gerrit-HasComments: Yes
