Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8274 )
Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+ ...................................................................... Patch Set 1: Code-Review+1 (3 comments) This looks fine to me, with minor comment nits. http://gerrit.cloudera.org:8080/#/c/8274/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8274/1//COMMIT_MSG@13 PS1, Line 13: N.B. this is probably worth fixing upstream. We are upstream! http://gerrit.cloudera.org:8080/#/c/8274/1/tests/metadata/test_hdfs_encryption.py File tests/metadata/test_hdfs_encryption.py: http://gerrit.cloudera.org:8080/#/c/8274/1/tests/metadata/test_hdfs_encryption.py@191 PS1, Line 191: # exists. This behavior is expected due to the difference in encryption zones "the difference in encryption zones between the .Trash and the warehouse directory" If that's true, could we elaborate on "difference in encryption zones" perhaps as suggested here? http://gerrit.cloudera.org:8080/#/c/8274/1/tests/metadata/test_hdfs_encryption.py@198 PS1, Line 198: # New HDFS behavior succeeds the query and creates trash; the partition removal s/New HDFS/HDFS 2.8+/? -- To view, visit http://gerrit.cloudera.org:8080/8274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30234aa50fea93f316e75beea2ced002dcea0c24 Gerrit-Change-Number: 8274 Gerrit-PatchSet: 1 Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Fri, 13 Oct 2017 22:07:59 +0000 Gerrit-HasComments: Yes
