Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8233 )
Change subject: IMPALA-6002: Add a LLVM diagnostic handler for LLVM linker errors ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/8233/3/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/8233/3/be/src/codegen/llvm-codegen.cc@308 PS3, Line 308: if (!diagnostic_err.empty()) ss << diagnostic_err; > nit: This might look like "... to main module.Bla bla." I.e., no space afte Done http://gerrit.cloudera.org:8080/#/c/8233/3/be/src/codegen/llvm-codegen.cc@1628 PS3, Line 1628: LOG(INFO) << diagnostic_handler->error_str_; > Include the query id for context, which should be accessible via state_? Wi Done http://gerrit.cloudera.org:8080/#/c/8233/3/be/src/codegen/llvm-codegen.cc@1634 PS3, Line 1634: (std:: > Should be able to drop the std:: - we import it into the namespace in commo Done http://gerrit.cloudera.org:8080/#/c/8233/3/be/src/codegen/llvm-codegen.cc@1635 PS3, Line 1635: error_str_.clear(); > I might be confused about the C++11 stuff, but given that you just std::mov Done http://gerrit.cloudera.org:8080/#/c/8233/3/be/src/codegen/llvm-codegen.cc@1635 PS3, Line 1635: error_str_.clear(); > Yup Done -- To view, visit http://gerrit.cloudera.org:8080/8233 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I907ff1f8975c02d422b4a669afbfc2e536ddf1ff Gerrit-Change-Number: 8233 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Mon, 16 Oct 2017 22:56:24 +0000 Gerrit-HasComments: Yes
