Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 )
Change subject: IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/8294/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8294/1//COMMIT_MSG@9 PS1, Line 9: JENKINS-1102 added the IAM role ImpalaDev to the Impala Jenkins workers : to facilitate s3 access without having to carry around AWS credentials : in environment variables, from where they were prone to escape to log : files posted in public places. This looks like something specific to a downstream environment and should be removed from the commit message. http://gerrit.cloudera.org:8080/#/c/8294/1/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/8294/1/bin/impala-config.sh@268 PS1, Line 268: test tests http://gerrit.cloudera.org:8080/#/c/8294/1/bin/impala-config.sh@276 PS1, Line 276: curl -sf --connect-timeout 1 --max-time 5 Are these curl options common across a wide variety of OSs? If they are newer and only work under, say, Ubuntu 16, they would be a problem for contributors using older distributions. http://gerrit.cloudera.org:8080/#/c/8294/1/bin/impala-config.sh@276 PS1, Line 276: http://169.254.169.254/latest/meta-data/iam/security-credentials/ Is there a AWS reference page you can add as a comment so I can read up more on this? http://gerrit.cloudera.org:8080/#/c/8294/1/testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.tmpl File testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.tmpl: http://gerrit.cloudera.org:8080/#/c/8294/1/testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.tmpl@61 PS1, Line 61: <!-- BEGIN s3 security settings --> Maybe have a comment explaining testdata/cluster/admin needs this (and the END) as a marker and not to remove? -- To view, visit http://gerrit.cloudera.org:8080/8294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14cd9d4453a91baad3c379aa7e4944993fca95ae Gerrit-Change-Number: 8294 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Tue, 17 Oct 2017 23:09:08 +0000 Gerrit-HasComments: Yes
