Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8238 )
Change subject: IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION. ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/8238/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/8238/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1958 PS7, Line 1958: Lists.partition(allHmsPartitionsToAdd, MAX_PARTITION_UPDATES_PER_RPC)) { While you are here, can you also change bulkAlterPartitions() to use Lists.partition()? http://gerrit.cloudera.org:8080/#/c/8238/7/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: http://gerrit.cloudera.org:8080/#/c/8238/7/tests/metadata/test_ddl.py@514 PS7, Line 514: def test_alter_table_create_many_partitions(self, vector, unique_database): This test doesn't belong in the TestLibCache class. Don't we have existing tests that test the multi-partition add alter? Seems like this test belongs there. http://gerrit.cloudera.org:8080/#/c/8238/7/tests/metadata/test_ddl.py@519 PS7, Line 519: self.client.execute('use {0}'.format(unique_database)) "use" can generally cause problems in tests because we sometimes run a test against different impalads for example to exercise sync_ddl. While I think it is ok in this specific instance, it's generally better practice not so issue "use" statements unless absolutely necessary. http://gerrit.cloudera.org:8080/#/c/8238/7/tests/metadata/test_ddl.py@527 PS7, Line 527: # 473 -1 0 0B NOT CACHED NOT CACHED TEXT false hdfs://localhost:20500/test-warehouse/test_alter_table_create_many_partitions_5b4888f5.db/t/p=473 This comment can become stale quickly. I suggest not adding it an output row verbatim but mentioning that show partitions contains the partition HDFS paths which we expect to contain p=val sub-directories that you are going to search for with the regex. -- To view, visit http://gerrit.cloudera.org:8080/8238 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95f8221ff08c0f126f951f7d37ff5e57985f855f Gerrit-Change-Number: 8238 Gerrit-PatchSet: 7 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Thu, 19 Oct 2017 03:40:11 +0000 Gerrit-HasComments: Yes
