Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8315 )
Change subject: IMPALA-4918: Support getting column comments via HS2 ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8315/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8315/2//COMMIT_MSG@9 PS2, Line 9: Fill the 'comments'/'remarks' field during HS2 column metadata requests. > Please include in the commit message how you tested this. I think this also Column comments were already working from impala shell/hue, the problem was JDBC/HS2 specific. There are several tests for comments, for example in functional-query/queries/QueryTest/alter-table.test. I have written some test steps - is it ok like this, or it should be closer to working java code? Kudu does not support column comments yet, I do not know about HBase. http://gerrit.cloudera.org:8080/#/c/8315/2/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java File fe/src/test/java/org/apache/impala/common/FrontendTestBase.java: http://gerrit.cloudera.org:8080/#/c/8315/2/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java@189 PS2, Line 189: dummyTable.addColumn( > Long line. Done http://gerrit.cloudera.org:8080/#/c/8315/2/fe/src/test/java/org/apache/impala/service/JdbcTest.java File fe/src/test/java/org/apache/impala/service/JdbcTest.java: http://gerrit.cloudera.org:8080/#/c/8315/2/fe/src/test/java/org/apache/impala/service/JdbcTest.java@460 PS2, Line 460: assertEquals("Incorrect table comment", "", rs.getString("REMARKS")); > This looks like a bug in getTables() to me, but Alex and Dimitris would kno It looked intentional ( https://gerrit.cloudera.org/#/c/6933/ ), but I am curious about the reasons. -- To view, visit http://gerrit.cloudera.org:8080/8315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d33dfd031b5344d7136695b623cec76143ada5c Gerrit-Change-Number: 8315 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Comment-Date: Thu, 19 Oct 2017 16:59:53 +0000 Gerrit-HasComments: Yes
