Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 )
Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro ...................................................................... Patch Set 9: (4 comments) Looks good http://gerrit.cloudera.org:8080/#/c/8146/9/be/src/exec/hdfs-scanner.cc File be/src/exec/hdfs-scanner.cc: http://gerrit.cloudera.org:8080/#/c/8146/9/be/src/exec/hdfs-scanner.cc@543 PS9, Line 543: *init_tuple_fn = : codegen->GetFunction(IRFunction::HDFS_SCANNER_INIT_TUPLE, true); single line? http://gerrit.cloudera.org:8080/#/c/8146/9/be/src/runtime/descriptors.cc File be/src/runtime/descriptors.cc: http://gerrit.cloudera.org:8080/#/c/8146/9/be/src/runtime/descriptors.cc@86 PS9, Line 86: ConstantAggregateZero* zeroes = : ConstantAggregateZero::get(null_indicator_offset_type); single line? http://gerrit.cloudera.org:8080/#/c/8146/9/be/src/runtime/tuple.h File be/src/runtime/tuple.h: http://gerrit.cloudera.org:8080/#/c/8146/9/be/src/runtime/tuple.h@182 PS9, Line 182: Status* status Its unusual to have s status as an out parameter instead of returning it. Could you document why you did this? http://gerrit.cloudera.org:8080/#/c/8146/9/be/src/runtime/tuple.h@184 PS9, Line 184: Helper for MaterializeStrings() If this isn't intended to be called outside this class, make it private? -- To view, visit http://gerrit.cloudera.org:8080/8146 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1fc78790d778c874f5aafa5958c3c045a88d233 Gerrit-Change-Number: 8146 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 19 Oct 2017 17:09:15 +0000 Gerrit-HasComments: Yes
