Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 )
Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder ...................................................................... Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/8034/10/be/src/exec/hdfs-parquet-scanner.h File be/src/exec/hdfs-parquet-scanner.h: http://gerrit.cloudera.org:8080/#/c/8034/10/be/src/exec/hdfs-parquet-scanner.h@352 PS10, Line 352: return mem_tracker_; if this is the same mem tracker in scan_node_ perhaps we can just do scan_node_->mem_tracker(); over here and avoid adding a new member variable? Same in the hdfs-table-writer. http://gerrit.cloudera.org:8080/#/c/8034/10/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/8034/10/be/src/exec/hdfs-parquet-scanner.cc@337 PS10, Line 337: if (mem_tracker_ != nullptr) { : mem_tracker_ = nullptr; : } nit: one line if (mem_tracker_ != nullptr) mem_tracker_ = nullptr; http://gerrit.cloudera.org:8080/#/c/8034/10/be/src/exec/parquet-column-readers.h File be/src/exec/parquet-column-readers.h: http://gerrit.cloudera.org:8080/#/c/8034/10/be/src/exec/parquet-column-readers.h@356 PS10, Line 356: if (dict_decoder_base_ != nullptr) dict_decoder_base_->Close(); instead of dict_decoder_base_ we can just use the virtual function GetDictionaryDecoder() to get the dict if it exists http://gerrit.cloudera.org:8080/#/c/8034/10/be/src/util/dict-encoding.h File be/src/util/dict-encoding.h: http://gerrit.cloudera.org:8080/#/c/8034/10/be/src/util/dict-encoding.h@206 PS10, Line 206: nit: extra line http://gerrit.cloudera.org:8080/#/c/8034/10/be/src/util/dict-encoding.h@324 PS10, Line 324: nit: extra line -- To view, visit http://gerrit.cloudera.org:8080/8034 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02a3b54f6c107d19b62ad9e1c49df94175964299 Gerrit-Change-Number: 8034 Gerrit-PatchSet: 10 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 19 Oct 2017 21:41:48 +0000 Gerrit-HasComments: Yes
