Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 )
Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq ...................................................................... Patch Set 4: (3 comments) Nice cleanup! I don't have much to say - patch makes a lot of sense to me. http://gerrit.cloudera.org:8080/#/c/8172/4/be/src/exec/hdfs-scanner.h File be/src/exec/hdfs-scanner.h: http://gerrit.cloudera.org:8080/#/c/8172/4/be/src/exec/hdfs-scanner.h@276 PS4, Line 276: std::vector<SlotOffsets> string_slot_offsets_; What's the reason for keeping a separate vector? We also have these in the scan node's tuple descriptor. http://gerrit.cloudera.org:8080/#/c/8172/4/be/src/exec/hdfs-scanner.h@341 PS4, Line 341: /// - 'copy_out_strings': if true, strings in returned tuples that pass conjuncts are copy_strings? http://gerrit.cloudera.org:8080/#/c/8172/4/be/src/exec/scanner-context.cc File be/src/exec/scanner-context.cc: http://gerrit.cloudera.org:8080/#/c/8172/4/be/src/exec/scanner-context.cc@110 PS4, Line 110: parent_->scan_node_->num_owned_io_buffers_.Add(-1); Not sure this counter is still useful. Do you think we can get rid of it? -- To view, visit http://gerrit.cloudera.org:8080/8172 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I304fd002b61bfedf41c8b1405cd7eb7b492bb941 Gerrit-Change-Number: 8172 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 20 Oct 2017 05:37:08 +0000 Gerrit-HasComments: Yes
