Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8350 )
Change subject: IMPALA-6068: Fix dataload for complextypes_fileformat ...................................................................... Patch Set 2: (1 comment) The next upload does two things: 1. It adds asserts to make sure CREATE and CREATE_HIVE can't both be specified and DEPENDENT_LOAD and DEPENDENT_LOAD_HIVE can't both be specified. 2. It changes the testescape* tables to use LOAD DATA statements (by printing them from text_delims_table.py). 3. Fixes a typo in one of the SQLs http://gerrit.cloudera.org:8080/#/c/8350/2/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/8350/2/testdata/bin/generate-schema-statements.py@528 PS2, Line 528: insert = eval_section(section['DEPENDENT_LOAD']) > Are these two sections intended to be mutually exclusive? If so, then we sh Added an assert that we don't specify both. -- To view, visit http://gerrit.cloudera.org:8080/8350 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7152306b2907198204a6d8d282a0bad561129b82 Gerrit-Change-Number: 8350 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Mon, 23 Oct 2017 22:08:15 +0000 Gerrit-HasComments: Yes
