Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/7564 )
Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE ...................................................................... Patch Set 11: (10 comments) Thanks for the review! http://gerrit.cloudera.org:8080/#/c/7564/10/be/src/service/fe-support.cc File be/src/service/fe-support.cc: http://gerrit.cloudera.org:8080/#/c/7564/10/be/src/service/fe-support.cc@455 PS10, Line 455: TQueryOptions options; > Thanks for investigating and providing an explanation! Done http://gerrit.cloudera.org:8080/#/c/7564/11/be/src/service/fe-support.cc File be/src/service/fe-support.cc: http://gerrit.cloudera.org:8080/#/c/7564/11/be/src/service/fe-support.cc@454 PS11, Line 454: JNIEnv* env, jclass caller_class, jstring options_str, jbyteArray tquery_options) { > rename options_str to csv_query_options for consistency Done http://gerrit.cloudera.org:8080/#/c/7564/10/fe/src/test/java/org/apache/impala/testutil/TestFileParser.java File fe/src/test/java/org/apache/impala/testutil/TestFileParser.java: http://gerrit.cloudera.org:8080/#/c/7564/10/fe/src/test/java/org/apache/impala/testutil/TestFileParser.java@288 PS10, Line 288: if (!currentTestCase.isValid()) { > All PlannerTest .test files should end with "====", so I think the code her Correct, every PlannerTest .test file ends with "====". I've removed parseQueryOptions() from L338. I find the code in L339-L344 very confusing. If the .test file doesn't end with "====", the last non-terminated test case is still validated and returned to the caller. In addition, if the very last section is not "----" terminated it will be silently ignored. Maybe we should do something like this instead: if (!currentTestCase.isEmpty() || !sectionContents.isEmpty()) { throw new IllegalStateException("Test case" + " at line " + currentTestCase.startLineNum + " is not '====' terminated."); } return currentTestCase; http://gerrit.cloudera.org:8080/#/c/7564/11/fe/src/test/java/org/apache/impala/testutil/TestFileParser.java File fe/src/test/java/org/apache/impala/testutil/TestFileParser.java: http://gerrit.cloudera.org:8080/#/c/7564/11/fe/src/test/java/org/apache/impala/testutil/TestFileParser.java@359 PS11, Line 359: " - " + e.getMessage()); > also pass in 'e' as the cause Done http://gerrit.cloudera.org:8080/#/c/7564/11/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-query-options.test File testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-query-options.test: http://gerrit.cloudera.org:8080/#/c/7564/11/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-query-options.test@38 PS11, Line 38: ---- DISTRIBUTEDPLAN > What's the value in keeping this section? I would like to keep it as a reference, so that we can see the effect of RUNTIME_FILTER_MODE=LOCAL in L339 and L422. http://gerrit.cloudera.org:8080/#/c/7564/11/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-query-options.test@174 PS11, Line 174: ---- DISTRIBUTEDPLAN > What's the value in keeping this section? Removed it. http://gerrit.cloudera.org:8080/#/c/7564/11/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-query-options.test@257 PS11, Line 257: ---- DISTRIBUTEDPLAN > What's the value in keeping this section? Removed it. http://gerrit.cloudera.org:8080/#/c/7564/11/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-query-options.test@392 PS11, Line 392: MAX_NUM_RUNTIME_FILTERS=4 > How about setting to 3 so we can see both local and non-local filters being Done http://gerrit.cloudera.org:8080/#/c/7564/11/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-query-options.test@582 PS11, Line 582: ---- DISTRIBUTEDPLAN > What's the value in keeping this section? Removed it. http://gerrit.cloudera.org:8080/#/c/7564/11/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-query-options.test@657 PS11, Line 657: ---- DISTRIBUTEDPLAN > What's the value in keeping this section? Removed it. -- To view, visit http://gerrit.cloudera.org:8080/7564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0f0b200e02442edcad8df3979f652d66c6e52eb Gerrit-Change-Number: 7564 Gerrit-PatchSet: 11 Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Wed, 25 Oct 2017 16:48:21 +0000 Gerrit-HasComments: Yes
