Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8385
Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows ...................................................................... IMPALA-2758: Remove BufferedTupleStream::GetRows This patch removes BufferedTupleStream::GetRows. This function pins a stream and reads all the rows into a single batch. It is not a good API since it creates an arbitrarily large row batch. In this patch the call sites pin the stream and then directly use GetNext to retrieve a single batch at a time. Testing: It passes existing tests. A test case for GetRows is removed. Change-Id: Ie7aaa9559183e9663c4617d626445fd6f9897eef --- M be/src/exec/partitioned-hash-join-node.cc M be/src/exec/partitioned-hash-join-node.h M be/src/runtime/buffered-tuple-stream-test.cc M be/src/runtime/buffered-tuple-stream.cc M be/src/runtime/buffered-tuple-stream.h 5 files changed, 57 insertions(+), 90 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/8385/1 -- To view, visit http://gerrit.cloudera.org:8080/8385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie7aaa9559183e9663c4617d626445fd6f9897eef Gerrit-Change-Number: 8385 Gerrit-PatchSet: 1 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>