Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 )
Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Change looks good to me - glad to see the code removed. Can the other reviewers take another look (or let me know if they don't intend to)? http://gerrit.cloudera.org:8080/#/c/8226/3/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: http://gerrit.cloudera.org:8080/#/c/8226/3/be/src/exec/partitioned-hash-join-node.cc@948 PS3, Line 948: DCHECK(got_reservation); Maybe add a DCHECK message like '<< "Should have been pinned"' to explain the DCHECK. http://gerrit.cloudera.org:8080/#/c/8226/3/be/src/exec/partitioned-hash-join-node.cc@1073 PS3, Line 1073: DCHECK(got_reservation); Same here -- To view, visit http://gerrit.cloudera.org:8080/8226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3831c38994da2b69775a9809ff01de5d23584414 Gerrit-Change-Number: 8226 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 26 Oct 2017 17:36:20 +0000 Gerrit-HasComments: Yes
