Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8412 )
Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test ...................................................................... Patch Set 2: (1 comment) Thanks for the explanation. http://gerrit.cloudera.org:8080/#/c/8412/2/be/src/rpc/thrift-server-test.cc File be/src/rpc/thrift-server-test.cc: http://gerrit.cloudera.org:8080/#/c/8412/2/be/src/rpc/thrift-server-test.cc@111 PS2, Line 111: string current_executable_path; Correct me if I'm wrong, but it seems like the root of the problem is that InitAuth() does not create a copy of the app name. To avoid problems like this in the future, how about we move this string to authentication.cc and have InitAuth() copy appname argument into this new string. Then callers of InitAuth() don't need to worry about the lifetime of the app name string they pass. -- To view, visit http://gerrit.cloudera.org:8080/8412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cd434757de2cd384def5b360a479e51812cccca Gerrit-Change-Number: 8412 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Mon, 30 Oct 2017 17:50:35 +0000 Gerrit-HasComments: Yes
