Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8426 )
Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Just curious, how does this change affect the total runtime of the core/exhaustive test-suite? +2'ing since the change is simple. http://gerrit.cloudera.org:8080/#/c/8426/1/fe/src/test/resources/hbase-site.xml.template File fe/src/test/resources/hbase-site.xml.template: http://gerrit.cloudera.org:8080/#/c/8426/1/fe/src/test/resources/hbase-site.xml.template@38 PS1, Line 38: <!-- Our tests expect to have 3 replicas. Force completing all replicas before acknowledging : writes to avoid test failures due to temporarily underreplicated blocks. --> : <property> : <name>dfs.namenode.replication.min</name> : <value>3</value> : </property> Isn't this redundant? Per my understanding, this only goes into HDFS service side settings and clients (HBase in this case) only control dfs.replication. -- To view, visit http://gerrit.cloudera.org:8080/8426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie09efdd9512cc4f0e338919af42bcdcede2cfb93 Gerrit-Change-Number: 8426 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Comment-Date: Tue, 31 Oct 2017 05:11:41 +0000 Gerrit-HasComments: Yes
