Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8428 )
Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable ...................................................................... Patch Set 1: (1 comment) Most of this looks mechanical, and it looked fine. You changed some 1-line if's into 3-line ifs, which may be against house style. We don't seem to have any tests for condition-variable.h. How did you test this? http://gerrit.cloudera.org:8080/#/c/8428/1/be/src/util/condition-variable.h File be/src/util/condition-variable.h: http://gerrit.cloudera.org:8080/#/c/8428/1/be/src/util/condition-variable.h@38 PS1, Line 38: void Wait(boost::unique_lock<boost::mutex>& lock) { I'm not yet familiar with this part of C++; why is 'inline' getting removed here? And 'struct' in line 47? -- To view, visit http://gerrit.cloudera.org:8080/8428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3085c6dcb42350b61244df6e7f091a1e7db356c9 Gerrit-Change-Number: 8428 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 31 Oct 2017 17:23:37 +0000 Gerrit-HasComments: Yes
