Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 )
Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/8305/11/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/8305/11/be/src/service/impala-http-handler.cc@303 PS11, Line 303: record.end_time_us - record.start_time_us; This may be broken if end_time_us is not set yet. The old code will use the current local time if end_time is not set yet but the new code may leave us a negative value. Sorry for missing that during review. -- To view, visit http://gerrit.cloudera.org:8080/8305 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I642a1d713597826bb7c15cd2ecb6638cb813a02c Gerrit-Change-Number: 8305 Gerrit-PatchSet: 11 Gerrit-Owner: Zoram Thanga <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Tue, 31 Oct 2017 17:49:31 +0000 Gerrit-HasComments: Yes
