Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 )
Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq ...................................................................... Patch Set 8: (3 comments) Michael, can you do the +2 for this one too? http://gerrit.cloudera.org:8080/#/c/8172/8/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/8172/8/be/src/exec/hdfs-scan-node.cc@238 PS8, Line 238: nit: a lot of unnecessary blank lines. maybe condense a bit so more code fits on a screen. http://gerrit.cloudera.org:8080/#/c/8172/8/be/src/exec/scanner-context.h File be/src/exec/scanner-context.h: http://gerrit.cloudera.org:8080/#/c/8172/8/be/src/exec/scanner-context.h@a184 PS8, Line 184: nice to see this get simplified http://gerrit.cloudera.org:8080/#/c/8172/8/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: http://gerrit.cloudera.org:8080/#/c/8172/8/be/src/runtime/row-batch.h@a215 PS8, Line 215: great to see this go -- To view, visit http://gerrit.cloudera.org:8080/8172 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I304fd002b61bfedf41c8b1405cd7eb7b492bb941 Gerrit-Change-Number: 8172 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 31 Oct 2017 18:21:18 +0000 Gerrit-HasComments: Yes
