Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8438 )
Change subject: IMPALA-6137: fix text scanner split delim mem mgmt ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/8438/4/be/src/exec/hdfs-text-scanner.h File be/src/exec/hdfs-text-scanner.h: http://gerrit.cloudera.org:8080/#/c/8438/4/be/src/exec/hdfs-text-scanner.h@90 PS4, Line 90: /// CheckForSplitDelimiter(). Valid if 'byte_buffer_filled_' is true. > Maybe briefly explain why we have it: the character is needed after the byt Done http://gerrit.cloudera.org:8080/#/c/8438/4/be/src/exec/hdfs-text-scanner.h@144 PS4, Line 144: virtual > I'm not following why we need a second virtual method. Is the wrapper meant We don't, that was my mistake. Removed the virtual. -- To view, visit http://gerrit.cloudera.org:8080/8438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddbb5cf6acc8f0b0e0b4c205c334f21e03d06f1c Gerrit-Change-Number: 8438 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Fri, 03 Nov 2017 17:40:39 +0000 Gerrit-HasComments: Yes
