Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 )
Change subject: IMPALA-6151: add query-level fragment/backend counters ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8461/2/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/8461/2/be/src/service/impala-server.cc@993 PS2, Line 993: RETURN_IF_ERROR(CancelInternal(query_id, check_inflight, cause)); What if we hit an error here? Need to still maintain the metric. http://gerrit.cloudera.org:8080/#/c/8461/2/be/src/service/impala-server.cc@1008 PS2, Line 1008: ImpaladMetrics::NUM_QUERIES_REGISTERED->Increment(-1L); To be most accurate, shouldn't we move this to the end of this function? There's still some non-trivial work in thus function after this point. http://gerrit.cloudera.org:8080/#/c/8461/2/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/8461/2/common/thrift/metrics.json@477 PS2, Line 477: "label": "Queries Registered", Imo we need to be careful with terminology. Our query states are already hard to reason about for users. How do the queries displayed in our "/queries" page relate to "registered" queries? I know the answer, but users might not due to confusion with what "registered", "in-flight", and "waiting-to-be-closed" mean. I don't really have a good alternative to "registered", but we should at least add in the description that "registered" refers to "in-flight" and "waiting-to-be-closed" queries from the "/queries" page. -- To view, visit http://gerrit.cloudera.org:8080/8461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3df350414733e98d1ec28adc1c98f45bb0c4e3e9 Gerrit-Change-Number: 8461 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 03 Nov 2017 23:51:36 +0000 Gerrit-HasComments: Yes
