Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 )
Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/8414/4/be/src/runtime/disk-io-mgr-reader-context.cc File be/src/runtime/disk-io-mgr-reader-context.cc: http://gerrit.cloudera.org:8080/#/c/8414/4/be/src/runtime/disk-io-mgr-reader-context.cc@50 PS4, Line 50: DCHECK(buffer->scan_range()->external_buffer_tag_ == ScanRange::ExternalBufferTag::NO_BUFFER) long line http://gerrit.cloudera.org:8080/#/c/8414/4/be/src/runtime/disk-io-mgr.cc File be/src/runtime/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/8414/4/be/src/runtime/disk-io-mgr.cc@462 PS4, Line 462: // Buffers the were not allocated by DiskIoMgr don't need to be freed. existing typo: that -- To view, visit http://gerrit.cloudera.org:8080/8414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5cb42437d11c13bc4a55c3ab426b66777332bd1 Gerrit-Change-Number: 8414 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Comment-Date: Sat, 04 Nov 2017 00:20:52 +0000 Gerrit-HasComments: Yes
