Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8449 )
Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8449/3/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/8449/3/be/src/statestore/statestore.cc@278 PS3, Line 278: lock_guard<SpinLock> l(subscribers_lock_); : lock_guard<mutex> t(topic_lock_); > IMO, we shouldn't use spinlock for topic_lock_ since we can potentially do My general opinion on this is "if it ain't broke, don't fix it". Do we have any evidence that these locks are a problem, or is this a case of premature optimization? In any case, this is not the main focus of this patch, so let's avoid creeping in unrelated changes. I vote for reverting. If we have evidence that a mutex is not good here, then let's change that in a separate patch. -- To view, visit http://gerrit.cloudera.org:8080/8449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0329ae7d23dc6e9b04b7bc3ee8d89cbc73756f65 Gerrit-Change-Number: 8449 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Mon, 06 Nov 2017 22:05:12 +0000 Gerrit-HasComments: Yes
