Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8428 )
Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable ...................................................................... Patch Set 2: (4 comments) Thanks, updated the code and hopefully resolved the merge conflict. http://gerrit.cloudera.org:8080/#/c/8428/2/be/src/runtime/data-stream-recvr.cc File be/src/runtime/data-stream-recvr.cc: http://gerrit.cloudera.org:8080/#/c/8428/2/be/src/runtime/data-stream-recvr.cc@220 PS2, Line 220: unique_lock > This change is harmless but doesn't seem necessary. Oops, I rewrote it when I started to work on "the mutex should be released by the time we call notify". This shouldn't be in this commit. Done. http://gerrit.cloudera.org:8080/#/c/8428/2/be/src/runtime/fragment-instance-state.cc File be/src/runtime/fragment-instance-state.cc: http://gerrit.cloudera.org:8080/#/c/8428/2/be/src/runtime/fragment-instance-state.cc@332 PS2, Line 332: auto wait_duration = boost::posix_time::seconds(report_fragment_offset); > The use of "auto" here is probably marginal as far as our coding idioms go. Done http://gerrit.cloudera.org:8080/#/c/8428/2/be/src/runtime/fragment-instance-state.cc@337 PS2, Line 337: auto wait_duration = boost::posix_time::seconds(FLAGS_status_report_interval); > This is pre-existing but we should avoid shadowing variables. Done http://gerrit.cloudera.org:8080/#/c/8428/2/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/8428/2/be/src/service/impala-server.cc@1800 PS2, Line 1800: session_timeout_cv_.WaitFor(timeout_lock, wait_duration); > nit: could just be a one liner. Done -- To view, visit http://gerrit.cloudera.org:8080/8428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3085c6dcb42350b61244df6e7f091a1e7db356c9 Gerrit-Change-Number: 8428 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 07 Nov 2017 14:58:17 +0000 Gerrit-HasComments: Yes
