Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8487 )
Change subject: IMPALA-5999: Fix LLVM linkage errors due LibCache sync issues ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8487/1/be/src/codegen/llvm-codegen-test.cc File be/src/codegen/llvm-codegen-test.cc: http://gerrit.cloudera.org:8080/#/c/8487/1/be/src/codegen/llvm-codegen-test.cc@485 PS1, Line 485: NULL > nullptr Done http://gerrit.cloudera.org:8080/#/c/8487/1/be/src/codegen/llvm-codegen.h File be/src/codegen/llvm-codegen.h: http://gerrit.cloudera.org:8080/#/c/8487/1/be/src/codegen/llvm-codegen.h@584 PS1, Line 584: LinkModule > Maybe LinkModuleFromLocalFs() or something like that to disambiguate it the Done -- To view, visit http://gerrit.cloudera.org:8080/8487 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefa23bbf47998fe7e84011e1edf8e794e94a1757 Gerrit-Change-Number: 8487 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 07 Nov 2017 21:15:23 +0000 Gerrit-HasComments: Yes
