Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8461 )
Change subject: IMPALA-6151: add query-level fragment/backend counters ...................................................................... IMPALA-6151: add query-level fragment/backend counters This adds NumBackends, NumFragments and NumFragmentInstances counters to the query profile to make it easier to manually or programmatically analyse the query. Also add a num-queries-registered metric to track the number of queries that have been executed but are not yet unregistered. Testing: Ran "select count(*) from alltypessmall" and checked profile: Backend startup latencies: Count: 3, min / max: 1ms / 1ms, 25th %-ile: 1ms, 50th %-ile: 1ms, 75th %-ile: 1ms, 90th %-ile: 1ms, 95th %-ile: 1ms, 99.9th %-ile: 1ms Per Node Peak Memory Usage: tarmstrong-box:22000(1.10 MB) tarmstrong-box:22001(1.02 MB) tarmstrong-box:22002(1.02 MB) - FiltersReceived: 0 (0) - FinalizationTimer: 0.000ns - NumBackends: 3 (3) - NumFragmentInstances: 4 (4) - NumFragments: 2 (2) Ran some query tests (both beeswax and HS2) and manually checked the num-queries-registered metric on the /metrics page when the queries were running and after they finished. Added the metric to test_metrics_are_zero() to make sure that there are no accounting errors. Change-Id: I3df350414733e98d1ec28adc1c98f45bb0c4e3e9 Reviewed-on: http://gerrit.cloudera.org:8080/8461 Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> Tested-by: Impala Public Jenkins --- M be/src/runtime/coordinator.cc M be/src/service/impala-server.cc M be/src/util/impalad-metrics.cc M be/src/util/impalad-metrics.h M common/thrift/metrics.json M tests/verifiers/metric_verifier.py 6 files changed, 37 insertions(+), 5 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3df350414733e98d1ec28adc1c98f45bb0c4e3e9 Gerrit-Change-Number: 8461 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>