Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8417 )
Change subject: IMPALA-2281: Replace FNV with FastHash in exchange nodes ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/8417/5/be/src/runtime/raw-value-test.cc File be/src/runtime/raw-value-test.cc: http://gerrit.cloudera.org:8080/#/c/8417/5/be/src/runtime/raw-value-test.cc@104 PS5, Line 104: FastHash > "FastHash" Done http://gerrit.cloudera.org:8080/#/c/8417/5/be/src/runtime/raw-value.h File be/src/runtime/raw-value.h: http://gerrit.cloudera.org:8080/#/c/8417/5/be/src/runtime/raw-value.h@74 PS5, Line 74: /// Get a 64-bit hash value using the FastHash function. > Please add a reference. https://www.google.com/search?q=fasthash doesn't di Done http://gerrit.cloudera.org:8080/#/c/8417/5/be/src/util/hash-util.h File be/src/util/hash-util.h: http://gerrit.cloudera.org:8080/#/c/8417/5/be/src/util/hash-util.h@32 PS5, Line 32: public: > Please add the name of this file in the appropriate place in LICENSE.txt. Y Done. I followed the practice in be/src/kudu/security/init.cc and assumed the license here should be removed. -- To view, visit http://gerrit.cloudera.org:8080/8417 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I778317d982dcdb94173a369a65b39f32b4f7ded2 Gerrit-Change-Number: 8417 Gerrit-PatchSet: 6 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 08 Nov 2017 01:14:14 +0000 Gerrit-HasComments: Yes
