Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 )
Change subject: IMPALA-4856: Port data stream service to KRPC ...................................................................... Patch Set 10: (6 comments) http://gerrit.cloudera.org:8080/#/c/8023/9/be/src/runtime/krpc-data-stream-mgr.cc File be/src/runtime/krpc-data-stream-mgr.cc: http://gerrit.cloudera.org:8080/#/c/8023/9/be/src/runtime/krpc-data-stream-mgr.cc@62 PS9, Line 62: FLAGS_datastream_service_num_deserialization_threads, 10000, > why disallow the setting of this greater than num_cores? Given that it take Yes. The assumption is that the critical section is small and most threads won't block for too long so no point in pushing above number of cores. To be consistent with other knobs we have (e.g. # service threads, reactor threads), we shouldn't impose an implicit upper bound. http://gerrit.cloudera.org:8080/#/c/8023/9/be/src/runtime/krpc-data-stream-recvr.cc File be/src/runtime/krpc-data-stream-recvr.cc: http://gerrit.cloudera.org:8080/#/c/8023/9/be/src/runtime/krpc-data-stream-recvr.cc@67 PS9, Line 67: the > the resources Done http://gerrit.cloudera.org:8080/#/c/8023/9/be/src/runtime/krpc-data-stream-recvr.cc@195 PS9, Line 195: current_ba > current_batch_ Done http://gerrit.cloudera.org:8080/#/c/8023/9/be/src/runtime/krpc-data-stream-recvr.cc@225 PS9, Line 225: DCHECK > shoudl we also DCHECK that num_pending_enqueue_ == 0 (otherwise, we could h Done http://gerrit.cloudera.org:8080/#/c/8023/9/be/src/runtime/krpc-data-stream-recvr.cc@248 PS9, Line 248: current_batch_.reset(resu > this is part of the same operation as line 244 (both are adjusting the queu Done http://gerrit.cloudera.org:8080/#/c/8023/9/be/src/runtime/krpc-data-stream-recvr.cc@252 PS9, Line 252: // It's important that the dequeuing of 'deferred_rpcs_' is done after the entry > how about moving this to line 250 now that it's that scope that drops the l Done -- To view, visit http://gerrit.cloudera.org:8080/8023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0b8c1e50678da66ab1547d16530f88b323ed8c1 Gerrit-Change-Number: 8023 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Wed, 08 Nov 2017 03:35:43 +0000 Gerrit-HasComments: Yes
