Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8408 )
Change subject: IMPALA-6121: remove I/O mgr request context cache ...................................................................... Patch Set 8: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/8408/8/be/src/runtime/disk-io-mgr-reader-context.h File be/src/runtime/disk-io-mgr-reader-context.h: http://gerrit.cloudera.org:8080/#/c/8408/8/be/src/runtime/disk-io-mgr-reader-context.h@27 PS8, Line 27: but some clients may need to include this header, e.g. to make the : /// unique_ptr<DiskIoRequestContext> destructor work correctly. : /// that's really unfortunate, but the change is a net win. http://gerrit.cloudera.org:8080/#/c/8408/7/be/src/runtime/disk-io-mgr.h File be/src/runtime/disk-io-mgr.h: http://gerrit.cloudera.org:8080/#/c/8408/7/be/src/runtime/disk-io-mgr.h@654 PS7, Line 654: std::unique_ptr<DiskIoRequestContext> RegisterContext(MemTracker* reader_mem_tracker); > I think it's an implementation detail the RegisterContext() doesn't registe I wasn't thinking in terms of implementation. I was thinking in terms of the interface -- how can a context be "registered" when the caller doesn't pass a context to be registered? Anyway, I'm fine with leaving the terminology alone in this change. http://gerrit.cloudera.org:8080/#/c/8408/8/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: http://gerrit.cloudera.org:8080/#/c/8408/8/be/src/runtime/runtime-state.h@39 PS8, Line 39: class DiskIoRequestContext; delete -- To view, visit http://gerrit.cloudera.org:8080/8408 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91414eceaa4938fccd74686fe6bebede6ef36108 Gerrit-Change-Number: 8408 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 13 Nov 2017 22:05:47 +0000 Gerrit-HasComments: Yes