Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8500 )
Change subject: Pin gen_build_version's git handling to typical git dir. ...................................................................... Patch Set 1: I'm seeing a compile error here. https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/613/console. Seems unrelated, so we'll probably try again later? 21:19:41 [ 34%] Building CXX object be/src/udf/CMakeFiles/Udf.dir/udf-test-harness.cc.o 21:19:41 /home/ubuntu/Impala-lzo/hdfs-lzo-text-scanner.cc: In member function ‘impala::Status impala::HdfsLzoTextScanner::ReadAndDecompressData(impala::MemPool*)’: 21:19:41 /home/ubuntu/Impala-lzo/hdfs-lzo-text-scanner.cc:589:44: error: no matching function for call to ‘impala::ScannerContext::ReleaseCompletedResources(bool)’ 21:19:41 context_->ReleaseCompletedResources(false); 21:19:41 ^ 21:19:41 /home/ubuntu/Impala-lzo/hdfs-lzo-text-scanner.cc:589:44: note: candidate is: 21:19:41 In file included from /home/ubuntu/Impala/be/src/exec/hdfs-scanner.h:31:0, 21:19:41 from /home/ubuntu/Impala/be/src/exec/hdfs-text-scanner.h:22, 21:19:41 from /home/ubuntu/Impala-lzo/hdfs-lzo-text-scanner.h:9, 21:19:41 from /home/ubuntu/Impala-lzo/hdfs-lzo-text-scanner.cc:22: 21:19:41 /home/ubuntu/Impala/be/src/exec/scanner-context.h:298:8: note: void impala::ScannerContext::ReleaseCompletedResources(impala::RowBatch*, bool) 21:19:41 void ReleaseCompletedResources(RowBatch* batch, bool done); 21:19:41 ^ 21:19:41 /home/ubuntu/Impala/be/src/exec/scanner-context.h:298:8: note: candidate expects 2 arguments, 1 provided -- To view, visit http://gerrit.cloudera.org:8080/8500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98870a1cb2073ddcf9ba1620e3801e1964930edd Gerrit-Change-Number: 8500 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Mon, 13 Nov 2017 22:19:18 +0000 Gerrit-HasComments: No
