Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8436 )
Change subject: IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/8436/4/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/8436/4/be/src/exec/parquet-column-readers.cc@934 PS4, Line 934: null > nullptr Done http://gerrit.cloudera.org:8080/#/c/8436/4/be/src/exec/parquet-column-readers.cc@942 PS4, Line 942: // 3. If the column type is not string, and the dictionary page is not compressed, > I'm not 100% confident that we have test coverage for this case - we have s I have checked, and this branch is executed if exploration strategy > core. http://gerrit.cloudera.org:8080/#/c/8436/4/be/src/exec/parquet-column-readers.cc@944 PS4, Line 944: ScopedBuffer uncompressed_buffer(parent_->dictionary_pool_->mem_tracker()); > nit: unnecessary blank line Done http://gerrit.cloudera.org:8080/#/c/8436/4/be/src/exec/parquet-column-readers.cc@964 PS4, Line 964: > nit: != nullptr (we prefer explicit checks against null to make it visually Done -- To view, visit http://gerrit.cloudera.org:8080/8436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d9d5f4da1028d961155dafdac0028a1c3641004 Gerrit-Change-Number: 8436 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 14 Nov 2017 00:14:08 +0000 Gerrit-HasComments: Yes
