Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 )
Change subject: IMPALA-5754: Improve randomness of rand()/random() ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8355/3/be/src/util/rand-util.h File be/src/util/rand-util.h: http://gerrit.cloudera.org:8080/#/c/8355/3/be/src/util/rand-util.h@28 PS3, Line 28: static double generate(std::mt19937& generator, const double min, const double max); > It will not necessarily be possible or wise to replace all IMPALA-4954 uses Thanks for adding the e2e tests. I'd still recommend the file removals referenced in this comment. -- To view, visit http://gerrit.cloudera.org:8080/8355 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idafdd5fe7502ff242c76a91a815c565146108684 Gerrit-Change-Number: 8355 Gerrit-PatchSet: 3 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Comment-Date: Tue, 14 Nov 2017 05:25:02 +0000 Gerrit-HasComments: Yes
