Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8543 )
Change subject: IMPALA-5341: Avoid unintended filter out in fe test ...................................................................... Patch Set 1: (1 comment) I would like to add a test which contains wrong row-size value and the test should show that an error always happen. Unfortunately, I haven't found any similar case from testdata. I thought JUnit test, but E2E test should be required in this case. http://gerrit.cloudera.org:8080/#/c/8543/1/fe/src/test/java/org/apache/impala/testutil/TestUtils.java File fe/src/test/java/org/apache/impala/testutil/TestUtils.java: http://gerrit.cloudera.org:8080/#/c/8543/1/fe/src/test/java/org/apache/impala/testutil/TestUtils.java@96 PS1, Line 96: private final static String FILTER_KEY = "\\ssize="; I think this approach is very simple, but it's enough to avoid the unexpected filter out. Please comment with examples if it might make any side effect. -- To view, visit http://gerrit.cloudera.org:8080/8543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie79f644a37b0ffab7b0d8e94e77650d56423697a Gerrit-Change-Number: 8543 Gerrit-PatchSet: 1 Gerrit-Owner: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Comment-Date: Tue, 14 Nov 2017 08:29:27 +0000 Gerrit-HasComments: Yes
