Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8368 )
Change subject: IMPALA-2235: Fix current db when shell auto-reconnects ...................................................................... Patch Set 5: (1 comment) Thanks for the review http://gerrit.cloudera.org:8080/#/c/8368/4/tests/custom_cluster/test_shell_interactive_reconnect.py File tests/custom_cluster/test_shell_interactive_reconnect.py: http://gerrit.cloudera.org:8080/#/c/8368/4/tests/custom_cluster/test_shell_interactive_reconnect.py@60 PS4, Line 60: start_num_queries = impalad.get_metric_value(NUM_QUERIES) > Would "p.send_cmd("show tables"); p.get_result()" make this stable, without Yeah I also felt wrong about the sleep for the same reason, but didn't know any better. Unfortunately get_result() closes STDIN and that exits the Impala shell process. But, looking at other test codes I figured out how I can use the ImpaladService class to wait for my USE command. -- To view, visit http://gerrit.cloudera.org:8080/8368 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I40dfa00ba0314d356fe8617446f516505c925e5e Gerrit-Change-Number: 8368 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 14 Nov 2017 23:27:55 +0000 Gerrit-HasComments: Yes
