Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8548 )
Change subject: IMPALA-5052: Read and write signed integer logical types in Parquet ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8548/1/tests/query_test/test_insert_parquet.py File tests/query_test/test_insert_parquet.py: http://gerrit.cloudera.org:8080/#/c/8548/1/tests/query_test/test_insert_parquet.py@303 PS1, Line 303: create_tbl_stmt = """create table {0} like parquet "{1} " Why is there a space after {1}? http://gerrit.cloudera.org:8080/#/c/8548/1/tests/query_test/test_insert_parquet.py@321 PS1, Line 321: insert_stmt = "insert into table {0} values(1, 2, 3, 4, 5)".format(dst_tbl); remove semicolon http://gerrit.cloudera.org:8080/#/c/8548/1/tests/query_test/test_insert_parquet.py@331 PS1, Line 331: result_dst = self.execute_query("describe %s" % dst_tbl) If we got both FE and BE wrong (mapping smallint to int32 for example) I think this test could still pass. How about adding an assertion on the schema? -- To view, visit http://gerrit.cloudera.org:8080/8548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47a8371858c9597c6a440808cf6f933532468927 Gerrit-Change-Number: 8548 Gerrit-PatchSet: 1 Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Wed, 15 Nov 2017 02:50:49 +0000 Gerrit-HasComments: Yes
