Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8544 )
Change subject: IMPALA-5362 : Preserve case-sensitivity in field titles ...................................................................... Patch Set 1: (10 comments) Testing (in a dry run; will not talk back to gerrit) here: https://jenkins.impala.io/job/gerrit-verify-dryrun/1474/ http://gerrit.cloudera.org:8080/#/c/8544/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8544/1//COMMIT_MSG@9 PS1, Line 9: nit: no space before comma http://gerrit.cloudera.org:8080/#/c/8544/1//COMMIT_MSG@9 PS1, Line 9: To preserve case sensitivity in column labels , this patch modifies the getColumnLabel() Please wrap commit messages at 72 characters. You can do this in emacs (if you use emacs for your commit message writing) by hitting ctrl-q. http://gerrit.cloudera.org:8080/#/c/8544/1//COMMIT_MSG@10 PS1, Line 10: return original "return the original" http://gerrit.cloudera.org:8080/#/c/8544/1//COMMIT_MSG@10 PS1, Line 10: However since nit: "However, since" http://gerrit.cloudera.org:8080/#/c/8544/1//COMMIT_MSG@11 PS1, Line 11: lowercase a nit: "lowercase, a" http://gerrit.cloudera.org:8080/#/c/8544/1//COMMIT_MSG@12 PS1, Line 12: SelectStmt.java.lowercase This is not a packagae name. Reword? http://gerrit.cloudera.org:8080/#/c/8544/1//COMMIT_MSG@12 PS1, Line 12: causing union test to fail hence replaced nit: "causing the union test to fail, hence I replace" http://gerrit.cloudera.org:8080/#/c/8544/1/fe/src/main/java/org/apache/impala/analysis/SelectListItem.java File fe/src/main/java/org/apache/impala/analysis/SelectListItem.java: http://gerrit.cloudera.org:8080/#/c/8544/1/fe/src/main/java/org/apache/impala/analysis/SelectListItem.java@97 PS1, Line 97: lower case remove http://gerrit.cloudera.org:8080/#/c/8544/1/fe/src/main/java/org/apache/impala/analysis/SelectListItem.java@98 PS1, Line 98: lower case remove http://gerrit.cloudera.org:8080/#/c/8544/1/fe/src/main/java/org/apache/impala/analysis/SelectListItem.java@99 PS1, Line 99: lower case remove -- To view, visit http://gerrit.cloudera.org:8080/8544 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia574f0b7d5bdbebace270ce4079632bf29b3f00e Gerrit-Change-Number: 8544 Gerrit-PatchSet: 1 Gerrit-Owner: [email protected] Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Comment-Date: Wed, 15 Nov 2017 18:22:06 +0000 Gerrit-HasComments: Yes
