Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8510 )
Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow ...................................................................... Patch Set 2: Thanks for doing this. It seems reasonable to me to switch to CTR. One concern I have is were you able to test this on a system with OpenSSL 1.0.0? Their documentation isn't clear, so I'm not sure if this API is supported in that version. The best I could see was this line of code that was under an #if 0: https://github.com/openssl/openssl/blob/OpenSSL_1_0_0-stable/crypto/evp/evp.h#L782-L783 It would be great if you could verify that. -- To view, visit http://gerrit.cloudera.org:8080/8510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib97939f2334838263364b53ef3413871638bf53e Gerrit-Change-Number: 8510 Gerrit-PatchSet: 2 Gerrit-Owner: Xianda Ke <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Mike Yoder <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 15 Nov 2017 19:27:26 +0000 Gerrit-HasComments: No
