Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 )
Change subject: IMPALA-3436: Return a decimal when rounding a double ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/8398/3/common/function-registry/impala_functions.py File common/function-registry/impala_functions.py: http://gerrit.cloudera.org:8080/#/c/8398/3/common/function-registry/impala_functions.py@285 PS3, Line 285: [['round_v1','dround_v1'], > Users typically aren't happy with workarounds that involve changing their q There are plenty of edge cases though where users that relied on decimal_v1 behaviour would have to modify their queries to use decimal_v2 semantics, so that's unavoidable when we remove decimal_v1. My concern was that in this case, even if they can modify their queries, then there is no rounding function that can take a variable precision. http://gerrit.cloudera.org:8080/#/c/8398/3/common/function-registry/impala_functions.py@285 PS3, Line 285: [['round_v1','dround_v1'], > If users rely on that behavior they can use DECIMAL_V1. We're not keeping decimal_v1 around indefinitely though are we? Seems more of a pain to file a JIRA and go through code review again than to just add an alias to the existing floating-point rounding function. -- To view, visit http://gerrit.cloudera.org:8080/8398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I240ec70da7996bbfefcf6438eba4dff8d33d7bd6 Gerrit-Change-Number: 8398 Gerrit-PatchSet: 3 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 15 Nov 2017 23:03:41 +0000 Gerrit-HasComments: Yes
