MyXOF commented on a change in pull request #32: fix sonar issues
URL: https://github.com/apache/incubator-iotdb/pull/32#discussion_r251705579
##########
File path:
iotdb/src/main/java/org/apache/iotdb/db/engine/memcontrol/JVMMemController.java
##########
@@ -58,46 +57,44 @@ public UsageLevel getCurrLevel() {
@Override
public void clear() {
-
- }
-
- @Override
- public void close() {
- super.close();
+ // JVMMemController does not need cleaning
}
@Override
public UsageLevel reportUse(Object user, long usage) {
long memUsage = getTotalUsage() + usage;
if (memUsage < warningThreshold) {
- /*
- * logger.debug("Safe Threshold : {} allocated to {}, total usage {}",
- * MemUtils.bytesCntToStr(usage), user.getClass(),
MemUtils.bytesCntToStr(memUsage));
- */
return UsageLevel.SAFE;
} else if (memUsage < dangerouseThreshold) {
- logger.debug("Warning Threshold : {} allocated to {}, total usage {}",
- MemUtils.bytesCntToStr(usage),
- user.getClass(), MemUtils.bytesCntToStr(memUsage));
+ if (logger.isDebugEnabled()) {
+ logger.debug("Warning Threshold : {} allocated to {}, total usage {}",
+ MemUtils.bytesCntToStr(usage),
+ user.getClass(), MemUtils.bytesCntToStr(memUsage));
+ }
return UsageLevel.WARNING;
} else {
- logger.warn("Memory request from {} is denied, memory usage : {}",
user.getClass(),
- MemUtils.bytesCntToStr(memUsage));
+ if (logger.isWarnEnabled()) {
+ logger.warn("Memory request from {} is denied, memory usage : {}",
user.getClass(),
Review comment:
logger统一写法
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
