MyXOF commented on a change in pull request #32: fix sonar issues
URL: https://github.com/apache/incubator-iotdb/pull/32#discussion_r251705278
##########
File path:
iotdb/src/main/java/org/apache/iotdb/db/engine/memtable/MemTableFlushUtil.java
##########
@@ -36,62 +37,47 @@
public class MemTableFlushUtil {
private static final Logger logger =
LoggerFactory.getLogger(MemTableFlushUtil.class);
- private static final int PAGE_SIZE_THRESHOLD = TSFileDescriptor.getInstance()
- .getConfig().pageSizeInByte;
+ private static final int PAGE_SIZE_THRESHOLD = TSFileConfig.pageSizeInByte;
private MemTableFlushUtil(){
}
- private static int writeOneSeries(List<TimeValuePair> tvPairs, IChunkWriter
seriesWriterImpl,
+ private static void writeOneSeries(List<TimeValuePair> tvPairs, IChunkWriter
seriesWriterImpl,
TSDataType dataType)
throws IOException {
- int count = 0;
- switch (dataType) {
- case BOOLEAN:
- for (TimeValuePair timeValuePair : tvPairs) {
- count++;
- seriesWriterImpl
- .write(timeValuePair.getTimestamp(),
timeValuePair.getValue().getBoolean());
- }
- break;
- case INT32:
- for (TimeValuePair timeValuePair : tvPairs) {
- count++;
- seriesWriterImpl.write(timeValuePair.getTimestamp(),
timeValuePair.getValue().getInt());
- }
- break;
- case INT64:
- for (TimeValuePair timeValuePair : tvPairs) {
- count++;
- seriesWriterImpl.write(timeValuePair.getTimestamp(),
timeValuePair.getValue().getLong());
- }
- break;
- case FLOAT:
- for (TimeValuePair timeValuePair : tvPairs) {
- count++;
- seriesWriterImpl.write(timeValuePair.getTimestamp(),
timeValuePair.getValue().getFloat());
- }
- break;
- case DOUBLE:
- for (TimeValuePair timeValuePair : tvPairs) {
- count++;
- seriesWriterImpl
- .write(timeValuePair.getTimestamp(),
timeValuePair.getValue().getDouble());
- }
- break;
- case TEXT:
- for (TimeValuePair timeValuePair : tvPairs) {
- count++;
- seriesWriterImpl
- .write(timeValuePair.getTimestamp(),
timeValuePair.getValue().getBinary());
- }
- break;
- default:
- logger.error("don't support data type: {}", dataType);
- break;
+ for (TimeValuePair timeValuePair : tvPairs) {
+ switch (dataType) {
+ case BOOLEAN:
+ seriesWriterImpl
+ .write(timeValuePair.getTimestamp(),
timeValuePair.getValue().getBoolean());
+ break;
+ case INT32:
+ seriesWriterImpl.write(timeValuePair.getTimestamp(),
+ timeValuePair.getValue().getInt());
+ break;
+ case INT64:
+ seriesWriterImpl.write(timeValuePair.getTimestamp(),
+ timeValuePair.getValue().getLong());
+ break;
+ case FLOAT:
+ seriesWriterImpl.write(timeValuePair.getTimestamp(),
+ timeValuePair.getValue().getFloat());
+ break;
+ case DOUBLE:
+ seriesWriterImpl
+ .write(timeValuePair.getTimestamp(),
+ timeValuePair.getValue().getDouble());
+ break;
+ case TEXT:
+ seriesWriterImpl
+ .write(timeValuePair.getTimestamp(),
timeValuePair.getValue().getBinary());
+ break;
+ default:
+ logger.error("don't support data type: {}", dataType);
Review comment:
logger统一写法
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
