jixuan1989 commented on a change in pull request #34: fix sonar 
URL: https://github.com/apache/incubator-iotdb/pull/34#discussion_r251695185
 
 

 ##########
 File path: 
tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/decoder/BitmapDecoder.java
 ##########
 @@ -38,6 +30,10 @@
  * Decoder switch or enums value using bitmap, bitmap-encoding:. {@code 
<length> <num>
  * <encoded-data>}
  */
+
+/**
+ * @deprecated (2019.1.25, why, refactoring advice)
 
 Review comment:
   > ??
   
   This method is not used now, because we remove the bitmap data type...(But I 
think we can reserve this class, and reuse it later...)
   In the master branch, there is a @Deprecated (see line 37). Maybe Sonar 
requires us explain why in Javadoc. 
   @LeiRui , the @deprecated annotation should be in the same paragraph with ` 
Decoder switch or enums value using bitmap, bitmap-encoding:. {@code <length> 
<num>  <encoded-data>}`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to