kr11 commented on a change in pull request #35: Fix sonar tianyu
URL: https://github.com/apache/incubator-iotdb/pull/35#discussion_r252104183
##########
File path: iotdb/src/main/java/org/apache/iotdb/db/metadata/MTree.java
##########
@@ -34,8 +34,13 @@
public class MTree implements Serializable {
private static final long serialVersionUID = -4200394435237291964L;
- private final String space = " ";
- private final String separator = "\\.";
+ private static final String space = " ";
Review comment:
The constant string should be regularized by `"[A-Z]*"`. Furthermore, the
name `name` is too generic and meaningless, maybe rename it by quadruple space,
like `QUAD_SPACE`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
