jixuan1989 commented on a change in pull request #32: fix sonar issues
URL: https://github.com/apache/incubator-iotdb/pull/32#discussion_r253120624
##########
File path:
iotdb/src/main/java/org/apache/iotdb/db/engine/overflow/io/OverflowResource.java
##########
@@ -184,9 +186,10 @@ public void flush(FileSchema fileSchema, IMemTable
memTable,
timeInterval = timeInterval == 0 ? 1 : timeInterval;
long insertSize = insertIO.getPos() - startPos;
LOGGER.info(
- "Overflow processor {} flushes overflow insert data, actual:{}, time
consumption:{} ms, flush rate:{}/s",
- processorName, MemUtils.bytesCntToStr(insertSize), timeInterval,
- MemUtils.bytesCntToStr(insertSize / timeInterval * 1000));
+ "Overflow processor {} flushes overflow insert data, actual:{},
time consumption:{} ms,"
+ + " flush rate:{}/s",
+ processorName, MemUtils.bytesCntToStr(insertSize), timeInterval,
Review comment:
wrap this log with if(LOGGER.isInfoEnabled()) is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
