LeiRui commented on a change in pull request #34: fix sonar
URL: https://github.com/apache/incubator-iotdb/pull/34#discussion_r257545160
##########
File path:
tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/common/EncodingConfig.java
##########
@@ -25,6 +21,10 @@
*/
public class EncodingConfig {
+ private EncodingConfig() {
+ throw new IllegalAccessError("Utility class");
Review comment:
https://rules.sonarsource.com/java/tag/design/RSPEC-1118
> Utility classes, which are collections of static members, are not meant to
be instantiated. Even abstract utility classes, which can be extended, should
not have public constructors.
>
> Java adds an implicit public constructor to every class which does not
define at least one explicitly. Hence, at least one non-public constructor
should be defined.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
