MyXOF commented on a change in pull request #62: add a new parameter for maven:
-Duse.local.thrift.compiler (false by default)
URL: https://github.com/apache/incubator-iotdb/pull/62#discussion_r259606329
##########
File path: pom.xml
##########
@@ -64,6 +64,11 @@
<sonar.host.url>https://builds.apache.org/analysis</sonar.host.url>
<!-- Exclude all generated code -->
<sonar.exclusions>**/generated-sources</sonar.exclusions>
+ <!-- whether using a thrift compiler locally
+ (if false, maven will download a binary thrift compiler).
+ if true, you must set the thrift compiler into your PATH, and make sure
+ the version is ${thrift.version}-->
+ <use.local.thrift.compiler>false</use.local.thrift.compiler>
Review comment:
if i use `mvn clean compile -Duse.local.thrift.compiler=true` command, both
`thrift-download-and-generation` and `thrift-generation-using-local-compiler`
will be triggered?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
