LeiRui opened a new pull request #241:  Refactor the reader package for 
readability
URL: https://github.com/apache/incubator-iotdb/pull/241
 
 
   The former code in the org.apache.iotdb.db.query.reader package is
   somewhat diffcult to read.
   
   Through this refactor, three main tasks are completed:
   
   * the three levels of readers are made explicit: chunkRelated <
   resoureRelated < seriesReader
   
   * the two interfaces for creating the unsequence readers in
   SeriesReaderFactoryImpl are removed. Instead, two classes 
   UnseqResourceMergeReader and UnseqResourceReaderByTimestamp 
   are used. This change brings two benefits: a) SeriesReaderFactoryImpl 
   is thus focused purely on the creation of series readers and acts as a 
   middleman between query executor and data reader.b) The classes for 
   sequence and unsequence classes are symmetric finally.
   
   * Add JAVA annotations and improve related tests.
   
   A bug in the `hasNext` method in the class `SequenceSeriesByTimestamp` 
   (originally named `SequenceSeriesReader`) is also fixed.
   
   A possible future advancement is to deduplicate the code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to